fix: don't send emails to VMs that were requested but not created #54
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "fix-dead-instance-invoices"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
SUMMARY
dash.models.Instance
is created upon request andinfrastructure.models.InstanceCreated
when the instance is created. Using data fromInstanceCreated
to send invoices should solve this issue.fixes: https://gitea.gna.org/Hostea/dashboard/issues/53
draft: fix: don't send emails to VMs that were requested but not createdto WIP: draft: fix: don't send emails to VMs that were requested but not createdWIP: draft: fix: don't send emails to VMs that were requested but not createdto WIP: fix: don't send emails to VMs that were requested but not createdWIP: fix: don't send emails to VMs that were requested but not createdto fix: don't send emails to VMs that were requested but not createdIt looks good but needs rebasing. Also the CI did not run on this one apparently?
I think I opened this PR when we were migrating and Woodpecker was temorarily broken. I'll rebase and push changes, maybe the CI will pick it up this time 🤞
e023c25f25
to2298e4e75c
fix: don't send emails to VMs that were requested but not createdto WIP: fix: don't send emails to VMs that were requested but not created2298e4e75c
to6d68446a9c
6d68446a9c
to3ebc518e1f
WIP: fix: don't send emails to VMs that were requested but not createdto fix: don't send emails to VMs that were requested but not created@dachary: I rebased against
master
and the tests discovered a couple of bugs in my code(reference to nonexistent variable and the invalid name thing). Both of them are fixed and this PR is ready for your review :)