fix: don't send emails to VMs that were requested but not created #54

Merged

dachary merged 1 commits from fix-dead-instance-invoices into master

2022-09-11 23:07:41 +00:00

realaravinth commented

2022-09-04 12:23:49 +00:00

Owner

SUMMARY
dash.models.Instance is created upon request and infrastructure.models.InstanceCreated when the instance is created. Using data from InstanceCreated to send invoices should solve this issue.

fixes: https://gitea.gna.org/Hostea/dashboard/issues/53

SUMMARY `dash.models.Instance` is created upon request and `infrastructure.models.InstanceCreated` when the instance is created. Using data from `InstanceCreated` to send invoices should solve this issue. fixes: https://gitea.gna.org/Hostea/dashboard/issues/53

realaravinth added 1 commit 2022-09-04 12:23:49 +00:00

e023c25f25

fix: don't send emails to VMs that were requested but not created

SUMMARY
    dash.models.Instance is created upon request and
    infrastructure.models.InstanceCreated when the instance is created.
    Using data from InstanceCreated to send invoices should solve this
    issue.

realaravinth changed title from ~~draft: fix: don't send emails to VMs that were requested but not created~~ to WIP: draft: fix: don't send emails to VMs that were requested but not created

2022-09-04 12:23:55 +00:00

realaravinth changed title from ~~WIP: draft: fix: don't send emails to VMs that were requested but not created~~ to WIP: fix: don't send emails to VMs that were requested but not created

2022-09-04 12:24:03 +00:00

realaravinth changed title from ~~WIP: fix: don't send emails to VMs that were requested but not created~~ to fix: don't send emails to VMs that were requested but not created

2022-09-11 17:55:02 +00:00

realaravinth requested review from dachary 2022-09-11 17:55:11 +00:00

dachary commented

2022-09-11 20:37:02 +00:00

Owner

It looks good but needs rebasing. Also the CI did not run on this one apparently?

👍 1

realaravinth commented

2022-09-11 20:48:51 +00:00

Poster

Owner

Also the CI did not run on this one apparently?

I think I opened this PR when we were migrating and Woodpecker was temorarily broken. I'll rebase and push changes, maybe the CI will pick it up this time 🤞

> Also the CI did not run on this one apparently? I think I opened this PR when we were migrating and Woodpecker was temorarily broken. I'll rebase and push changes, maybe the CI will pick it up this time 🤞

👍 1

realaravinth force-pushed fix-dead-instance-invoices from e023c25f25 to 2298e4e75c

2022-09-11 20:58:04 +00:00

Compare

realaravinth changed title from ~~fix: don't send emails to VMs that were requested but not created~~ to WIP: fix: don't send emails to VMs that were requested but not created

2022-09-11 22:09:46 +00:00

realaravinth force-pushed fix-dead-instance-invoices from 2298e4e75c to 6d68446a9c

2022-09-11 22:26:51 +00:00

Compare

realaravinth force-pushed fix-dead-instance-invoices from 6d68446a9c to 3ebc518e1f

2022-09-11 22:35:51 +00:00

Compare

realaravinth changed title from ~~WIP: fix: don't send emails to VMs that were requested but not created~~ to fix: don't send emails to VMs that were requested but not created

2022-09-11 22:39:11 +00:00

realaravinth commented

2022-09-11 22:41:34 +00:00

Poster

Owner

@dachary: I rebased against master and the tests discovered a couple of bugs in my code(reference to nonexistent variable and the invalid name thing). Both of them are fixed and this PR is ready for your review :)

@dachary: I rebased against `master` and the tests discovered a couple of bugs in my code(reference to nonexistent variable and the invalid name thing). Both of them are fixed and this PR is ready for your review :)

👍 1

dachary approved these changes 2022-09-11 23:07:20 +00:00