Hostea
/
dashboard
2
2
Fork 1
Code Issues 11 Pull Requests Projects Releases Wiki Activity

git config before push #43

Merged
realaravinth merged 1 commits from dachary/dashboard:wip-config-3 into master 2022-07-08 14:18:00 +00:00
Conversation 1 Commits 1 Files Changed 7
dachary commented 2022-07-08 14:07:02 +00:00
Owner
  • refactor infrastructure/utils.py to use sh instead of GitPython
  • do not set config with --global in the CI to avoid side effects that hide problems in the implementation
  • cleanup to make ./venv/bin/flake8 infrastructure/utils.py infrastructure/tests.py happy (mostly unused imports / variables) so that it can spot typos before sending to the CI
  • fix bug by which when removing files try: except: could skip the remove of a some files if one of them do not exist
* refactor infrastructure/utils.py to use sh instead of GitPython * do not set config with --global in the CI to avoid side effects that hide problems in the implementation * cleanup to make `./venv/bin/flake8 infrastructure/utils.py infrastructure/tests.py` happy (mostly unused imports / variables) so that it can spot typos before sending to the CI * fix bug by which when removing files try: except: could skip the remove of a some files if one of them do not exist
dachary added 1 commit 2022-07-08 14:07:02 +00:00
ci/woodpecker/pr/woodpecker Pipeline failed Details
6e84746a2c
git config before push
dachary requested review from realaravinth 2022-07-08 14:07:09 +00:00
dachary commented 2022-07-08 14:10:09 +00:00
Poster
Owner

https://woodpecker.hostea.org/dachary/dashboard/build/17 passes for 6e84746a2c

https://woodpecker.hostea.org/dachary/dashboard/build/17 passes for https://gitea.hostea.org/Hostea/dashboard/commit/6e84746a2cb29b0e7bd901fe7db6b841534614c0
realaravinth approved these changes 2022-07-08 14:17:47 +00:00
realaravinth left a comment
Owner

Thanks for the PR, migration is a huge pain and using the library cluelessly is a bigger pain!

Thanks for the PR, migration is a huge pain and using the library cluelessly is a bigger pain!
realaravinth merged commit cb6bce0c44 into master 2022-07-08 14:18:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
realaravinth
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hostea/dashboard#43
There is no content yet.
Delete Branch "dachary/dashboard:wip-config-3"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?