Hostea
/
dashboard
2
2
Fork 1
Code Issues 11 Pull Requests Projects Releases Wiki Activity

git config before push #42

Closed
dachary wants to merge 0 commits from dachary:wip-config-2 into master
pull from: dachary:wip-config-2
merge into: Hostea:master
Conversation 3 Commits - Files Changed -
dachary commented 2022-07-08 13:58:36 +00:00
Owner
  • refactor infrastructure/utils.py to use sh instead of GitPython
  • do not set config with --global in the CI to avoid side effects that hide problems in the implementation
  • cleanup to make ./venv/bin/flake8 infrastructure/utils.py infrastructure/tests.py happy (mostly unused imports / variables) so that it can spot typos before sending to the CI
  • fix bug by which when removing files try: except: could skip the remove of a some files if one of them do not exist
* refactor infrastructure/utils.py to use sh instead of GitPython * do not set config with --global in the CI to avoid side effects that hide problems in the implementation * cleanup to make `./venv/bin/flake8 infrastructure/utils.py infrastructure/tests.py` happy (mostly unused imports / variables) so that it can spot typos before sending to the CI * fix bug by which when removing files try: except: could skip the remove of a some files if one of them do not exist
dachary added 1 commit 2022-07-08 13:58:36 +00:00
ci/woodpecker/pr/woodpecker Pipeline failed Details
6e84746a2c
git config before push
dachary commented 2022-07-08 14:04:38 +00:00
Poster
Owner

The PR check fails but the CI in my branch passes for the same SHA

https://woodpecker.hostea.org/dachary/dashboard/build/15

I did not investigate why a PR CI fails even when a branch CI passes

The PR check fails but the CI in my branch passes for the same SHA https://woodpecker.hostea.org/dachary/dashboard/build/15 I did not investigate why a PR CI fails even when a branch CI passes
dachary requested review from realaravinth 2022-07-08 14:04:44 +00:00
dachary commented 2022-07-08 14:05:58 +00:00
Poster
Owner

This pull request is broken due to missing fork information.

I'm quite sure this is a Gitea bug I've seen somewhere, I'll open a new PR

> This pull request is broken due to missing fork information. I'm quite sure this is a Gitea bug I've seen somewhere, I'll open a new PR
dachary closed this pull request 2022-07-08 14:06:06 +00:00
realaravinth commented 2022-07-08 14:09:11 +00:00
Owner

The PR check fails but the CI in my branch passes for the same SHA

https://woodpecker.hostea.org/dachary/dashboard/build/15

I did not investigate why a PR CI fails even when a branch CI passes

Not sure why woodpecker isn't setting CI_COMMIT_AUTHOR_EMAIL for PRs. The bug is in my CI config. I refer to branch builds before merging, so no worries :)

I'll fix that when I put out the existing fires out

> The PR check fails but the CI in my branch passes for the same SHA > > https://woodpecker.hostea.org/dachary/dashboard/build/15 > > I did not investigate why a PR CI fails even when a branch CI passes Not sure why woodpecker isn't setting `CI_COMMIT_AUTHOR_EMAIL` for PRs. The bug is in my CI config. I refer to branch builds before merging, so no worries :) I'll fix that when I put out the existing fires out
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
realaravinth
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hostea/dashboard#42
There is no content yet.
Delete Branch "dachary:wip-config-2"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?