Hostea
/
dashboard
2
2
Fork 1
Code Issues 11 Pull Requests Projects Releases Wiki Activity

hotfix: use dashboard/local_settings.py instead of env vars #4

Merged
dachary merged 1 commits from hotfix-local-settings-env-var-clash into master 2022-06-25 21:28:50 +00:00
Conversation 2 Commits 1 Files Changed 2
realaravinth commented 2022-06-25 20:23:21 +00:00
Owner

My env var loading technique is not allowing local_settings.py to
override settings.py. This hotfix disables env vars in favor of
local_settings.py.

fixes https://gitea.hostea.org/Hostea/dashboard/issues/3

My env var loading technique is not allowing local_settings.py to override settings.py. This hotfix disables env vars in favor of local_settings.py. fixes https://gitea.hostea.org/Hostea/dashboard/issues/3
realaravinth self-assigned this 2022-06-25 20:23:21 +00:00
realaravinth added 1 commit 2022-06-25 20:23:21 +00:00
ci/woodpecker/pr/woodpecker Pipeline failed Details
ci/woodpecker/push/woodpecker Pipeline failed Details
3378e61606
hotfix: use dashboard/local_settings.py instead of env vars 
My env var loading technique is not allowing local_settings.py to
override settings.py. This hotfix disables env vars in favor of
local_settings.py.

fixes https://gitea.hostea.org/Hostea/dashboard/issues/3
realaravinth requested review from dachary 2022-06-25 20:23:36 +00:00
dachary approved these changes 2022-06-25 20:49:25 +00:00
dachary commented 2022-06-25 20:50:00 +00:00
Owner

Did you verify it passes your tests?

Did you verify it passes your tests?
dachary merged commit 3378e61606 into master 2022-06-25 21:28:50 +00:00
realaravinth commented 2022-06-25 22:11:19 +00:00
Poster
Owner

It does, I'll implement the pending tests now

It does, I'll implement the pending tests now
Sign in to join this conversation.
Reviewers
No reviewers
dachary
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
realaravinth
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hostea/dashboard#4
There is no content yet.
Delete Branch "hotfix-local-settings-env-var-clash"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?