From ca8bb56d6c0b7e9eae1892f4da6c24f7c5425237 Mon Sep 17 00:00:00 2001 From: realaravinth Date: Sat, 18 Jun 2022 19:53:26 +0530 Subject: [PATCH] fix: logout route was being served by wrong handler and tests --- accounts/tests.py | 10 ++++++++++ accounts/urls.py | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/accounts/tests.py b/accounts/tests.py index e2665b5..a8e1ca2 100644 --- a/accounts/tests.py +++ b/accounts/tests.py @@ -99,6 +99,16 @@ class LoginTest(TestCase): self.assertEqual(resp.status_code, 302) self.assertEqual(resp.headers["location"], reverse("dash.home")) + def test_logout_works(self): + """ + Logout view tests + """ + c = Client() + login_util(t=self, c=c, redirect_to="accounts.home") + resp = c.get(reverse("accounts.logout")) + self.assertEqual(resp.status_code, 302) + self.assertEqual(resp.headers["location"], reverse("accounts.login")) + def test_default_login_uri_works(self): """ /accounts/login should redirect_to /login diff --git a/accounts/urls.py b/accounts/urls.py index 5070368..97b6971 100644 --- a/accounts/urls.py +++ b/accounts/urls.py @@ -29,7 +29,7 @@ from .views import ( urlpatterns = [ path("login/", login_view, name="accounts.login"), path("register/", register_view, name="accounts.register"), - path("logout/", login_view, name="accounts.logout"), + path("logout/", logout_view, name="accounts.logout"), path("accounts/login/", default_login_url, name="accounts.default_login_url"), path( "accounts/verify/pending//",